We will need a written plan of action to follow certain requests. We currently (and unspokenly) get 1-3 reviewers (depending on the size of a patch) to merge something into master.
For admins on GitHub, I’d propose the following review approval numbers, based on the scope of the PR. Note that the person taking this action counts as 1 approving review.
For example, if you were to create a PR to fix a typographic error, you can merge it immediately, since you are implicitly the 1 approving review needed to merge.
|Type of PR||Min Approvals|
|Typographic correction or phrasing in documentation or associated text||1|
|Non-breaking small code refactor or feature implementation||2|
|Any Medium to Large size change||3 - 4|
|Any breaking change||4|
|Any large feature||4|
The catch here: These numbers are arbitrary for the most part. I’m not a trained software dev or project manager, so if you have a better solution please bring that up! The above is more or less an example.